[kwokctl] Support version skew #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/feature
✅ Deploy Preview for k8s-kwok ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
wzshiming
force-pushed
the
feat/version-skew
branch
from
df9339c to
21e7d55
Compare
wzshiming
force-pushed
the
feat/version-skew
branch
5 times, most recently
from
921eb0f to
3bde502
Compare
Zhuzhenghao
reviewed
Jun 9, 2023
|
|
||
| // KwokctlConfigurationStatus holds information about the status. | ||
| type KwokctlConfigurationStatus struct { | ||
| // Version is the version of the kwokctl. |
There was a problem hiding this comment.
Is Version this meaning?
Version is the version of kwokctl that created this cluster.
wzshiming
force-pushed
the
feat/version-skew
branch
from
3bde502 to
fa6ddd9
Compare
wzshiming
force-pushed
the
feat/version-skew
branch
from
fa6ddd9 to
ea8314f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: